commit | 3ba488167d9054a4b5ad4c2bab2f607ad5b69258 | [log] [tgz] |
---|---|---|
author | Vinny Persky <vinnypersky@google.com> | Tue Jan 11 20:13:53 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 11 20:13:53 2022 |
tree | a9649560a18a100e8d4971fdbb1613c8569a8063 | |
parent | 6522f2f6d06c890184461dc733d1dcff9d53dc47 [diff] |
Card Art Image Fetching Refactor for M2-specific use cases This CL refactors the GetCreditCardArtImageForUrl function for M2-specific use-cases. In M2 we can have 3 possible cases for card art image fetching for the card we want to enroll into VCN: Case I: We can retrieve the card art image from the local cache after the Save Card Response. This CL does not change the functionality of this situation. Case II & Case III: We try to retrieve the card art image from the local cache after the Save Card Response, but fail to do so. Thus we will send a server call to fetch the image. Right before showing the VirtualCardEnrollmentBubble, no matter if we are able to retrieve the card art image from the local cache (Case II) or not (Case III), this CL will save a fetch server call, as at this point we only need to try to retrieve the card art image from the local cache by calling GetCachedCardArtImageForUrl() or else we will be double fetching. For all other use cases where we fetch after trying to retrieve card art images from the local cache, this CL will not alter functionality. DD: https://docs.google.com/document/d/1nxpjPQEtYhgdMfEarIaYHXhxNcYyQ3NgDGPvA_1OjwA/edit#heading=h.bat9awopsp53 Change-Id: I0bc1dfc80473ffab0d4baaf7aaadc9adc127873a Bug: 1281695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3360062 Reviewed-by: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Matthias Körber <koerber@google.com> Commit-Queue: Vinny Persky <vinnypersky@google.com> Cr-Commit-Position: refs/heads/main@{#957683}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.