Google Git
Sign in
chromium / chromium / src / 3bb3bcc8e5e8a43493529ff51d2dab71a6f6f272
commit3bb3bcc8e5e8a43493529ff51d2dab71a6f6f272[log] [tgz]
authorLijin Shen <lazzzis@google.com>Thu Nov 07 02:10:45 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 07 02:10:45 2024
treef397115e900f0b6d7bb28b6b9e6af7b0c5a96c50
parent3a046b253fe1f6b38467fe59927608fadf09a211 [diff]
[DNT] Fix crash caused by not navigable page when user starts to swipe

It turns out that sometimes the stage of whether the page is navigable
is not correctly tracked. Sometimes, the onBackStarted is called even
when the page is not navigable.

This CL adds another check to see if tab can be navigated back. If not,
handler will not be created and will fallback to tab history back press
handler; in this case, it will return a BackPressResult.Failure and
fallback to other handlers.

The Android.BackPress.Failure will also be recorded at this case.

Bug: 376928606
Change-Id: I56bebd8200130ed5e2cd7892d8d2a2cebab6f2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001437
Auto-Submit: Lijin Shen <lazzzis@google.com>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379416}
1 file changed
tree: f397115e900f0b6d7bb28b6b9e6af7b0c5a96c50
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.