commit 3bcf2be7de7d5fa468fd766202fa434ab89eee1c
author Morten Stenshorne <mstensho@chromium.org> Thu Oct 12 16:37:39 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 12 16:37:39 2023
tree 631314e2c35fbbc2e0fbf4ccd7ed266a1ed8fc67
parent bde7a44dbafd634f6fda22545f16f5cca5653695

Reland: Recalculate style before setting ICB size for printing.

One change, compared to the initial attempt: Set zero page margins in
the browser test, to avoid crbug.com/1491775

Original commit comment follows:

A zoom factor used when viewing a webpage on screen may have been set in
computed style. This would affect @page margin resolution incorrectly
when entering print mode, which in turn would result in an incorrect
initial containing block size. To fix this, recalculate style before
calculating the page area size.

Since we now recalculate style before setting any initial containing
block size for printing at all, viewport units will not be resolved
correctly. So make sure that they get calculated before laying out. This
used to be triggered by calling LayoutViewportWasResized(). It turns out
though, now that we need to do this unconditionally before the first
layout, that LayoutViewportWasResized() does more than we want. For
printing, we don't need to re-evaluate media queries, and we do not want
a resize event to be fired. Therefore, split the viewport units dirtying
into a separate function. Introduce a lambda in
ForceLayoutForPagination() to avoid repetitive code.

Make PrintBrowserTest.NoResizeEvent more evil, by modifying its resource
HTML file to use a named page, and also a wide DIV. This would make the
test fail without this CL.

Add external/wpt/css/printing/ to the scalefactor200 virtual test suite.
Three other tests (the already existing page-margin-xxx tests) would
also fail without this fix, but add a test for this specific issue
(abspos) as well.

(cherry picked from commit fc575639a9441664b3f079e57a2afbea068bb43f)

Bug: 1488751, 1486499
Change-Id: I716f8f9ca77769629ac71c0607aeef93824754b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4931752
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1208263}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4934372
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{#369}
Cr-Branched-From: 905e8bdd32d891451d94d1ec71682e989da2b0a1-refs/heads/main@{#1204232}