Fix arc keymaster bootstrapping with ipcz Arc keymaster code uses the Mojo invitations API to bootstrap multiple pipes to the keymaster server. It is the only known client which uses invitations the way that it does -- i.e., attaching multiple string-named pipes -- and this usage is not supported by MojoIpcz. The bootstrap code also does not account for the possibility of attachment failure, so this can lead to further bugs after attachment fails. This CL changes keymaster bootstrapping to use different (numeric) attachment names for the pipes when MojoIpcz is enabled, and it introduces graceful handling of attachment failures in case of future breakage. Fixed: 1379831 Change-Id: I11c6d5d6e4c3d9bf9bca955ad2ff21567ab66af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3995204 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1066341}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.