Google Git
Sign in
chromium / chromium / src / 3c1716f58840f2a454b6bc4188dd798656fb0d84
commit3c1716f58840f2a454b6bc4188dd798656fb0d84[log] [tgz]
authorRebekah Potter <rbpotter@chromium.org>Mon Oct 24 17:21:02 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 24 17:21:02 2022
tree65c91cb376a9c08aabdf84a28b84a5bf7222a871
parent2627454f56cedcd2fc168815070331a6123cd793 [diff]
WebUI: narrow ownership for chrome_web_ui_controller_factory.cc

chrome_web_ui_controller_factory.cc is generally updated whenever a new
WebUI surface is added. Such additions should be reviewed by WebUI
PLATFORM_OWNERS to ensure they follow the guidance in the documentation.
This added review is necessary since WebUI surfaces are user visible,
increase the size of the binary, and are frequently kept around
indefinitely. Recent additions of new WebUI surfaces that contradict
major parts of the WebUI documentation (e.g., using JavaScript instead
of TypeScript - see
https://bugs.chromium.org/p/chromium/issues/detail?id=1376982) further
demonstrate the need for this additional review.

Change-Id: I78d6c696685b830f285d9970e1cd702f239a7ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968982
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1062881}
2 files changed
tree: 65c91cb376a9c08aabdf84a28b84a5bf7222a871
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.