commit | ef17805121d38b2f4999f3b431bd0f4c02a8538b | [log] [tgz] |
---|---|---|
author | Takashi Sakamoto <tasak@google.com> | Wed Aug 11 06:36:48 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 11 06:36:48 2021 |
tree | bc06a0fbee9ac56c4024ffbba3d51e93d859840e | |
parent | 523ff4ca1898dde9d6cceabf718dae773a997d6a [diff] |
Revert "[ios] Disables TabGridTestCase.testTabGridBulkActionShare on device." This reverts commit 304823aaf051c66ceedc837eff8e7ae0bc36fa7f. Reason for revert: suspect compile failure on ios-device. First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/ios-device/195558/overview Sample Log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8839233674417163504/+/u/compile/stdout?format=raw --- [1220/1703] OBJCXX obj/ios/chrome/browser/ui/tab_switcher/tab_grid/eg2_tests/tab_grid_egtest.o FAILED: obj/ios/chrome/browser/ui/tab_switcher/tab_grid/eg2_tests/tab_grid_egtest.o /opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -...(too long) ../../ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_egtest.mm:123:28: error: undeclared selector 'testTabGridBulkActionShare' [-Werror,-Wundeclared-selector] [self isRunningTest:@selector(testTabGridBulkActionShare)]) { ^ 1 error generated. ---- Original change's description: > [ios] Disables TabGridTestCase.testTabGridBulkActionShare on device. > > BUG=1238501 > > Change-Id: I2f0dbd330b48d62a66838acdc5bde8e54675eb78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3088473 > Auto-Submit: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#910626} Bug: 1238501 Change-Id: I5626e1f809d185f2203f51b05292466f9605f598 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3086887 Auto-Submit: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Owners-Override: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#910628}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.