commit 3c589af585e6925081619f2345db3ebd307936bb
author Samuel Huang <huangs@chromium.org> Mon Jan 23 21:09:20 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 23 21:09:20 2023
tree e10282d099e2b1f586ed50afb038fe1d11a11b00
parent 66478726234eb5b57e755240971365d158c304b3

[SuperSize] Add DEX aggregate string symbols for {type, {method, field}, prototype}.

Previously "code strings", i.e., DEX strings used by
  class -> method -> code
were extracted into separate symbols (aliased among classes). This
omitted strings that were used as identifiers (or ShortyDescriptor) for
{type, method, field, prototype}. These strings were counted in
"** .dex (unattributed)" symbols.

This CL updates SuperSize to create "aggregate symbols" to attribute
bytes for the aforementioned strings. Specifically:
* Type strings for type_id_item[].descriptor_idx as "** .dex (type)".
* Method strings for method_id_item[].name_idx as "** .dex (method)".
* Field strings for field_id_item[].name_idx as "** .dex (field)".
* Prototype strings for proto_id_item[].shorty_idx as
  "** .dex (prototype)".

A string can fall into multiple categories. To address these:
* {Method, field} strings are put into the same aggregate symbol due to
  frequent overlap.
* To avoid double-counting, apply the following prioritization among
  DEX strings:
    code (separate symbols) > type > {method, field} > prototype,
  i.e., code strings are excluded from aggregate string symbols;
  type strings are excluded from {{method, field}, prototype} string
  aggregate symbols, etc.

Details: In apkanalyzer.py:
* _GenDexStringsUsedByClasses(): Also yield |string_idx|, which is used
  to exclude code string symbols are not counted in aggregate symbols.
* _StringSymbolsFromDexFile(): Add the 3 aggregate symbols, using new
  inner helper _AddAggregateStringSymbol().

Bug: 1408543
Change-Id: I38a351b72630705247723f5848d9b0b71de905c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4183117
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1095818}