INPUT text field: Fix a chopped editing text issue.
This CL fixes crbug.com/576589. The editing text looked to be chopped because:
- the selected font height is taller than the specified |line-height|.
- the specified |height| is taller than the |line-height|.
- So, the inner-editor element is shorter though the INPUT box has enough space.
This CL fixes the problem by the following changes:
* Resetting CSS line-height if CSS height is specified.
In such case line-height makes no sense, and we don't need to clip the
inner-editor element with it.
However, this change causes a regression for crbug.com/519331. So we need
the change below. It's an alternative fix for crbug.com/519331 rather than
crbug.com/576589.
* Always center the inner-editor element vertically regardless of its height,
don't override the height, and clip editing text with controlClipRect().
Before this change, if the inner-editor height was taller than the INPUT box
height, we put the inner-editor element on the top edge of the INPUT box, and
overrode its height to clip the text.
Instead of it, we always center the inner-editor element vertically like
Firefox does. Also, this change also removes the quirky behavior such that
editing text poked INPUT padding and border.
BUG=576589, 461117, 361728
TEST=automated
Review URL: https://codereview.chromium.org/1584683002
Cr-Commit-Position: refs/heads/master@{#369975}
17 files changed
