Google Git
Sign in
chromium / chromium / src / 3ca14f33e1ef5a9ed3f36699c1b3aad92a4453c5
commit3ca14f33e1ef5a9ed3f36699c1b3aad92a4453c5[log] [tgz]
authorFergal Daly <fergal@chromium.org>Mon Dec 14 05:39:36 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Dec 14 05:39:36 2020
treebc5b2568613eaf997290166e7b351c07c7894618
parent7f579bfc603abc620d0009c7ad4107ddc9a9f958 [diff]
More debugging for this bug.

Looks like render_frame_created_ is getting reset to true inside
RenderFrameDeleted!

- extend the dump_on_render_frame_created_for_bug_1146573_ region to
catch this.
- add dump points inside RenderFrameDeleted. These seem redundant if the
the prior debugging works but I want to avoid yet another round.

Bug: 1146573
Change-Id: I93dfd0a89fd9b95fc3e86e68189195c3b9c6dc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586456
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836530}
2 files changed
tree: bc5b2568613eaf997290166e7b351c07c7894618
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.