disk_cache/sql: Optimize UpdateEntryLastUsed with a by-ResId variant

The existing method to update an entry's last_used timestamp required a
lookup by the entry's key (hash and string). This is inefficient when
the internal resource ID (res_id) is already known, as is the case in
SqlBackendImpl::HandleUpdateEntryLastUsedOperation.

This change introduces a new, more efficient variant,
UpdateEntryLastUsedByResId, which updates the database entry directly
using its primary key (res_id). The call site in SqlBackendImpl is
updated to take advantage of this.

The existing key-based method is renamed to UpdateEntryLastUsedByKey
for clarity.

Additionally, this change fixes a minor issue where
HandleUpdateEntryLastUsedOperation would attempt to update an entry
that had failed speculative creation. It now checks for a valid res_id
before proceeding.

Performance was measured by running the
`DiskCachePerfTest.SqlCacheBackendPerformance` test 10 times and taking
the median on an M4 Pro MacBook Pro (16-inch, Nov 2024).

|                              | ToT r1523417 | with this cl |
| -----------------------------|--------------|--------------|
| cache_entries_write_time     | 2,074.191 ms | 2,031.665 ms |
| cache_headers_read_time_cold |   850.153 ms |   836.924 ms |
| cache_headers_read_time_warm |   333.641 ms |   315.235 ms |
| cache_entries_read_time_cold | 1,204.297 ms | 1,141.335 ms |
| cache_entries_read_time_warm |   429.028 ms |   409.849 ms |

OBSOLETE_HISTOGRAMS=Replaced UpdateEntryLastUsed with UpdateEntryLastUsedByKey and UpdateEntryLastUsedByResId

Bug: 443171275
Change-Id: Ic8f0ff3700e5c45043de6a8eccfa8362b08c0157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6998495
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1523433}
7 files changed
tree: 4f3955ab2aa6d2e0b3fa4c615c15ab02ee2e45d0
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.