Google Git
Sign in
chromium / chromium / src / 3cc7d3af70d25da8b3e6a33aa7b69ba724aef820
commit3cc7d3af70d25da8b3e6a33aa7b69ba724aef820[log] [tgz]
authorChristoph Schwering <schwering@google.com>Fri Aug 26 21:22:29 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 26 21:22:29 2022
tree45aaa203d53c22b22bd7ee01b72c4e76d8e4aa66
parent0bb10aef2fc28687a7fb6f6bf9b11b94938a3df5 [diff]
[Autofill] Weaken necessary condition for asynchronous reparse.

This CL weakens the necessary condition CachedFormNeedsUpdate():
if a <select> field's options have changed, the form needs to be
updated.

This change fixes a bug in OnSelectFieldOptionsDidChange() if
AutofillAsyncParse is enabled:

OnSelectFieldOptionsDidChange() calls ParseFormAsync(), which
calls OnSelectFieldOptionsDidChangeImpl(). This CL ensures that if
a field's FormFieldData::options have changed, a re-parse and cache
update happens between OnSelectFieldOptionsDidChange() and
OnSelectFieldOptionsDidChangeImpl().

This issue does not exist if AutofillAsyncParse is disabled
because in this case, OnSelectFieldOptionsDidChangeImpl()
synchronously re-parses the form in any case.

Bug: 1309848, 1345089
Change-Id: Ifcaf0be823ee175948b9418d14755a7693a17649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858224
Commit-Queue: Christoph Schwering <schwering@google.com>
Quick-Run: Christoph Schwering <schwering@google.com>
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1039976}
1 file changed
tree: 45aaa203d53c22b22bd7ee01b72c4e76d8e4aa66
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.