commit 3ced970ed1e2bc4ef9e0d6fc93e315aa7db205fd
author Noémie St-Onge <noemies@google.com> Mon Sep 09 16:31:04 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 09 16:31:04 2024
tree e452d3146860a4e93f38e36b98f4d7f78e8e7c57
parent 34b6ef5fb552faf15b530b3b203597d4ed81d019

[iOSKAUpgrade] Update navigation buttons of card details page

This CL switches the left bar button of the credit card details page
from "Cancel" to "Done" when this page is the first one in the
navigation stack. Otherwise, a "Back" button is shown. This change is
intended to fix the confusion that comes with having a "Cancel" button
as the only option to dismiss a view that allows editing (can lead to
thinking that "Cancel" will undo the edits that were made).

This CL also makes the left bar button become "Cancel" whenever the page
enters edit mode. This is done by overriding
SettingsRootTableViewController's `-showCancelDuringEditing`. With this
change, and because the new "Done" button needs to be set after the view
is loaded, the `customLeftBarButtonItem` needs to be re-set in
AutofillCreditCardEditTableViewController so that the left bar button
switches back to "Done" when exiting edit mode.

Navigation buttons before:
https://drive.google.com/file/d/1hy3cZYUMjb3Lcetf6qhYLNtPkMNBehf4/view?usp=sharing&resourcekey=0-DhEUk9hKrMn8jmFaJ3WO3w

Navigation buttons after:
https://drive.google.com/file/d/1xda4aIoh7NYjbMuZJoMun12gLAo0NALb/view?usp=sharing&resourcekey=0-Q5SdP79AQiWGJc6TYtGUBg

Bug: 356822193
Change-Id: I2d4a43ec117159200569f8f753814c90aa48f554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5834390
Commit-Queue: Noémie St-Onge <noemies@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Vidhan Jain <vidhanj@google.com>
Cr-Commit-Position: refs/heads/main@{#1352795}