commit 3cfbff0f60196e7dbfc352e4320452a7da9ed109
author Lingqi Chi <lingqi@chromium.org> Tue Nov 05 06:41:01 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 05 06:41:01 2024
tree 050da00936926d1a6ec2f773f025bef4785a5f72
parent 09226580165f59425c29bb449921bdc3ebd901c9

Reland "Prerender: first impl to dry run painting on prerendering page"

This is a reland of commit ecb74d5ebc8ebb413e5fbd71f73c8e9679a9435a
The initial version caused crashes on LinkPreview pages.
Looking into the details, it turned out that:
- LinkPreview pages will be painted immediately, so it has its
  PaintArtifactCompositor, which holds the reference to the
  PaintArtifact created during painting.
- Dryrun step may create new PaintArtifact to replace the old one.
- When updating, the reference to the old PaintArtifact gets broken.
- And then PendingLayer in the compositor will visit a cleared
  PaintArtifact, which causes crash.
To fix it, we add a condition to check compositor's existence before
preparing the paint tree.

Original change's description:
> Prerender: first impl to dry run painting on prerendering page
>
> This CL triggers tree build right after renderer parsed the main DOM
> tree. CHCKEs on the browser side will guard the metric correctness.
> (See Ifd788c4b04f06a6b98caff1bb9df55af5fb8f07a)
> The following CLs will:
> 1. only trigger it for DSE.
> 2. add more metrics on the renderer side to verify the correctness.
>
> Bug: 40240492
> Change-Id: Icd94bad6a6ecfc5e492e4d9c4b4c227741c041d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912738
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
> Commit-Queue: Lingqi Chi <lingqi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1373803}

Bug: 40240492
Change-Id: I6b36032f88e8662318197ef3dabe18f630c5652f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981737
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378136}