Google Git
Sign in
chromium / chromium / src / 3d02861d3159f3f9de91f2b498958114c206830f
commit3d02861d3159f3f9de91f2b498958114c206830f[log] [tgz]
authorPeter Boström <pbos@chromium.org>Mon Jan 22 23:41:02 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 22 23:41:02 2024
tree9afcd8df12c2a2fb56c621c5fc9ca46b2a45677c
parent653676156e16baeec38edbd85fbd81a89930b61f [diff]
Revert "Add crash keys to VulkanSwapChain"

This reverts commit 1d83694ad09848526fca458ef4eb6b4739174ad5.

Reason for revert: Thread-unsafe use of crash keys.

The crash keys are shared across threads and without external
synchronization this does data race. It looks like the investigated
crbug.com/1246857 has been fixed, so hopefully it's not too bad to
remove this before we have crash primitives that are safe to use in this
manner.

Bug: 1509041

Original change's description:
> Add crash keys to VulkanSwapChain
>
> We speculate that vkQueuePresentKHR and vkAcquireNextImageKHR
> occasionally block and GPU process gets killed by GPU watchdog.
>
> This CL adds crash keys to determine if this happens.
>
> Bug: 1246857
> Change-Id: I5fd87d86aff1c972abcfc295e86aaaaf57a509a7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304122
> Auto-Submit: Jonathan Backer <backer@chromium.org>
> Commit-Queue: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#945712}

Bug: 1246857
Change-Id: I3306b5d3d5e67f5a9d97d89b50666ad0a9d93058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225853
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1250536}
1 file changed
tree: 9afcd8df12c2a2fb56c621c5fc9ca46b2a45677c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.