| commit | 3d158ed80c7bfed31fbbca9fd01dfc17d75e9025 | [log] [tgz] |
|---|---|---|
| author | Lingqi Chi <lingqi@chromium.org> | Fri Apr 18 02:09:08 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 18 02:09:08 2025 |
| tree | 65b347af86ed02e03bbe31fee2e4dfb345355c35 | |
| parent | 905eaa62484bcc7cae2afe3527254545b2690c18 [diff] |
Revert "Detangle cyclical references in CC metrics" This reverts commit 9719c449b29272a6101307c75368c9e02ac7b43c. Reason for revert: Failing on Linux MSAN https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/55337/overview Bug: 404588481 Original change's description: > Detangle cyclical references in CC metrics > > This refactor performs the following: > * Remove Add/Rem tracker calls from FSTC to CFRC > and move all logic to FSTC > * Have CFRC delegate active tracker calls to FSTC > * Make DFC a FSTC member rather than delegating > through CFRC > * Remove FrameSorter from DFC, move to CFRC globals > and register both DFC and FSTC as observers of > FrameSorter. This replaces Callback pattern with > the observer pattern. > * Rename former callbacks to "AddSortedFrame" so > they can use the same observer interface. > > Details here: go/chrome-cc-metrics-cyclical-deps > > Change-Id: Ib834e656488b756e136d1938b3d91efd343c9152 > Bug: 404588481 > Compile-Size: Size increase is unavoidable. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6431485 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Stacy Gaikovaia <gaiko@google.com> > Cr-Commit-Position: refs/heads/main@{#1448555} Bug: 404588481 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie44c32f7203ad112d9fdea9965f5f5f8c6adbdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6471869 Auto-Submit: Lingqi Chi <lingqi@chromium.org> Owners-Override: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1448712}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.