Google Git
Sign in
chromium / chromium / src / 3d49d76b5f024554b96872d83cef11a49ac51283
commit3d49d76b5f024554b96872d83cef11a49ac51283[log] [tgz]
authorAnkush Singh <ankushkush@google.com>Fri May 09 15:56:54 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 09 15:56:54 2025
tree641c165dfc32efbd4fb0f83aa8c961cbd7ad8859
parent5b0f8ef0e3ca94af455306b99bf06196e37c9b47 [diff]
[prefs] Store user_selected_types in a pref in local store

This CL tackles a bug in the newly introduced code for always syncing
priority prefs: Priority prefs not marked as always syncing do not
return the account value before sync service is initialized, i.e. before
DualLayerUserPrefStore::OnSyncServiceInitialized() is called. This is
because the user selected sync types are not yet known and we avoid
returning priority pref values if "preference" is not selected by the
user for sync. This bug _might_ affect services which request a priority
pref before this point.

With this CL, the user selected types are preserved from the previous
run in a local-only preference. This allows deciding whether to return
the account priority pref value right away. Any change to the user
selected types will get informed when
DualLayerUserPrefStore::OnSyncServiceInitialized() is called.

Bug: 412602018
Change-Id: I68e9c9b82b13d6a5357b0cca10c5454b750f47be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519735
Commit-Queue: Ankush Singh <ankushkush@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1458143}
4 files changed
tree: 641c165dfc32efbd4fb0f83aa8c961cbd7ad8859
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.