Google Git
Sign in
chromium / chromium / src / 3d7572860cb24c6c46f92e35338ff3f0823e01a8
commit3d7572860cb24c6c46f92e35338ff3f0823e01a8[log] [tgz]
authorTony Herre <toprice@chromium.org>Fri Dec 02 09:53:31 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 02 09:53:31 2022
tree03ab1279f8d1d448c75a71e109a28657a5a30a2a
parent74543cbe4030f395d55468bc9b1511960a3aea6f [diff]
Propagate device enumerate failures from MediaDevicesManager to JS

Add a result_code value to the response of
MediaStreamManager::EnumerateDevices and the associated mojom interface,
indicating if the enumeration succeeded, or the reason it failed.
Propagate this down to reject the enumerateDevices() promise in the JS
API. Also package the response up into a single mojom struct to make the
interface smaller while we're here.

Before the effort tracked in crbug.com/1313822, these errors would be
hidden by the camera capture service, and an empty list of cameras would
be propagated back up the stack as if it were a success. I've changed
all other callers of the enumerateDevice API (eg in getUserMedia,
AudioContext etc) to now handle an error in the same way, so no other
codepaths should change behaviour yet - TODOs have been added to track
propagating these errors further in appropriate ways.

Bug: 1313822
Change-Id: I457746c6ebd391d184c6dd2796127ac6dd80ed4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055531
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Tony Herre <toprice@chromium.org>
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078494}
23 files changed
tree: 03ab1279f8d1d448c75a71e109a28657a5a30a2a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.