Google GitGoogle Git
Sign in
chromium/chromium/src/3d8f79f659d8faae1c7cbe6f3d9d05aaa34e4aab
commit
3d8f79f659d8faae1c7cbe6f3d9d05aaa34e4aab
[log]
author
Ryan Tarpine <rtarpine@chromium.org>
Fri Dec 16 18:57:43 2022
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Dec 16 18:57:43 2022
tree
24c2f7802a0a5e4cda68bb3cc77d3cd6ae9778b0
parent
19c49f6475ee764facd8a9337c6d3094f674bd97 [diff]
Improve DIPSService/DIPSWebContentsObserver creation.

Only create DIPSService when dips::kFeature is enabled, and enable it by
default.

Rely on ProfileSelections to determine whether the service should be
created for a Profile. Configure it to allow regular (including
incognito) and OTR-only guest profiles.

Only create DIPSWebContentsObserver when DIPSService::Get() returns
non-null.

Bug: 1400451
Change-Id: I4c91c82157055d099da960cd1c738a281c6e77c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098585
Auto-Submit: Ryan Tarpine <rtarpine@chromium.org>
Reviewed-by: Joshua Hood <jdh@chromium.org>
Commit-Queue: Joshua Hood <jdh@chromium.org>
Quick-Run: Ryan Tarpine <rtarpine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084439}
6 files changed
tree: 24c2f7802a0a5e4cda68bb3cc77d3cd6ae9778b0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.