MediaRecorder: Don't provide I420A if CanEncodeAlphaChannel() is false

A video encoder using media::VideoEncoder implementation in
MediaRecorder path checks I420A is provided only if
CanEncodeAlphaChannel() is true.
However, VideoTrackRecoder provides I420A to an encoder even if
CanEncodeAlphaChannel() returns false when ARGB is input to
VideoTrackRecorder. This works with its own h264 software encoder
because it converts ARGB and ABGR to I420A and then drops its alpha
channel. Although media::VideoEncoder for h264 also handles I420A
internally, it doesn't handle ARGB and ABGR. That's said, it depends
on a format whether the encoder can encode alpha channel.
It is more reasonable to convert a format and drop its alpha channel
in VideoTrackRecorder::VideoEncoder common code.

Bug: 1441395
Test: content_browsertests --gtest_filter=ProprietaryCodec/WebRtcMediaRecorderTest
Change-Id: I81d61945be2d28ee6dcafe0c393c1af9bbaa5c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055073
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1230400}
2 files changed
tree: eead48fb980bf0013dc16dec26bf97ebe9aa9df9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.