commit | 3dbd1a8cb15f671f3d7f9d812c8e22c97bdba856 | [log] [tgz] |
---|---|---|
author | Hirokazu Honda <hiroh@chromium.org> | Wed Nov 29 02:34:50 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 29 02:34:50 2023 |
tree | eead48fb980bf0013dc16dec26bf97ebe9aa9df9 | |
parent | 44ac299157ea2956d25228423dabffc2c4a3cb8b [diff] |
MediaRecorder: Don't provide I420A if CanEncodeAlphaChannel() is false A video encoder using media::VideoEncoder implementation in MediaRecorder path checks I420A is provided only if CanEncodeAlphaChannel() is true. However, VideoTrackRecoder provides I420A to an encoder even if CanEncodeAlphaChannel() returns false when ARGB is input to VideoTrackRecorder. This works with its own h264 software encoder because it converts ARGB and ABGR to I420A and then drops its alpha channel. Although media::VideoEncoder for h264 also handles I420A internally, it doesn't handle ARGB and ABGR. That's said, it depends on a format whether the encoder can encode alpha channel. It is more reasonable to convert a format and drop its alpha channel in VideoTrackRecorder::VideoEncoder common code. Bug: 1441395 Test: content_browsertests --gtest_filter=ProprietaryCodec/WebRtcMediaRecorderTest Change-Id: I81d61945be2d28ee6dcafe0c393c1af9bbaa5c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5055073 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Markus Handell <handellm@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230400}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.