Google Git
Sign in
chromium / chromium / src / 3dcb9806cc30853c95c9b7a068b08fa1000bf33a
commit3dcb9806cc30853c95c9b7a068b08fa1000bf33a[log] [tgz]
authorErnesto Izquierdo Clua <eic@google.com>Thu Nov 14 16:29:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 14 16:29:20 2024
tree3f6f7eb97953f8c40e2816f20080a53d3ee5c1ee
parentb44845aec9c2f5f47ddcc75c169b3f74b9ae2181 [diff]
[ios] Attempt to fix race condition in ReauthenticationCoordinator

The crash stack seems to indicate that we're trying to pop the reauth
view controller before it is fully pushed into its navigation
controller. This patch tries to fix the issue by delaying reauth until
the reauth view controller is fully presented. From a UI perspective
the change is not very visible ( auth is triggered milliseconds later).

I also changed a DCHECK to a non fatal CHECK until milestone 135 to
monitor the issue on stable.

Fixed: 373081568
Change-Id: Icbad2dd2ff5c45463db95cef3b6489943ed067ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019865
Commit-Queue: Ernesto Izquierdo Clua <eic@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1383030}
2 files changed
tree: 3f6f7eb97953f8c40e2816f20080a53d3ee5c1ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.