| commit | 3dfc732d77c45c34d1fc83652e46df49d74ff985 | [log] [tgz] |
|---|---|---|
| author | Di Zhang <dizhangg@chromium.org> | Mon Aug 28 19:33:33 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 28 19:33:33 2023 |
| tree | f48916b0f823b8802705a7c1c0fa6fe005956cf9 | |
| parent | 1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202 [diff] |
Setting CSS value using cssom should show deprecation warning
We want to count usage for deprecated CSS values that are set
using CSSOM:
* .setProperty('appearance', val)
* style.appearance = val`
This patch changes the following functions so we can pass the
CSSParserContext from CSSParser::ParseValue to the
CSSParserFastPaths::ParseKeywordValue. This way, once we have confirmed
the CSS value is valid, we can count the feature usage and show the
console warning for upcoming deprecation.
CSSParser::ParseValue()
CSSParserFastPaths::MaybeParseValue()
-> Pass `const CSSParserContext* context` instead of `CSSParserMode parser_mode`
CSSParserFastPaths::ParseKeywordValue()
-> Pass `const CSSParserContext* context` instead of `CSSParserMode parser_mode`
CSSParserFastPaths::IsValidKeywordPropertyAndValue()
Change-Id: I84329cc05ee391d4bf99cfc9243fdb69d01c8a8d
Bug: 1426629, 924486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803079
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1189110}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.