[Lacros] Clean up LacrosExtensionAppsController::Launch().

LacrosExtensionAppsController::Launch() originally handles Chrome v2
Apps only, and we plan to extend it to handle Extensions opened by
File.app via fileBrowserHandler API. To prepare, this CL cleans up
LacrosExtensionAppsController. Details:
* Fix headers.
* Extract FinallyLaunch() to perform launch after preconditions are
  satisfied. Our upcoming change will change this extensively.
* Launch(): Previously if IsAppLaunchableWithoutEnabling() returns
  false, then the flow enables app asynchronously, and on completion,
  calls FinishedEnableFlow(), which then calls Launch() to retry. This
  "async recursion" is not robust. Since FinallyLaunch() is available,
  so the flow is redirected there instead.
* Create LaunchResult once in Launch() and pass it around.
* Extract lacros_extensions_util::DemuxId().
* Change LacrosExtensionAppsController to call DemuxId() instead of
  DemuxPlatformAppId(), since the class will handle Extensions now,
  in addition to Apps.

Bug: 1275654
Change-Id: I2c1cff86e211cd10a192fb5a6142b8aa85ca6033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543830
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984135}
4 files changed
tree: 9d68f1fc11031c7eafa1ad9e4737c926527a415c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.