Google Git
Sign in
chromium / chromium / src / 3e40e3e6f8eb90d0a729ce549cd31b1e39938165
commit3e40e3e6f8eb90d0a729ce549cd31b1e39938165[log] [tgz]
authorChris Lu <thegreenfrog@chromium.org>Wed May 01 15:53:26 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 01 15:53:26 2024
tree29797858a6030a6ada4e01e48b915c8c9157ae7c
parent037e0a4b6161c381d85d153fb9b5b8f38d891760 [diff]
[ios] Fix MagicStack UI Breakage when Toggling Feed off

This issue is result of the MagicStackCollectionView pulling in the
safe area insets when it never is within the safe area. For some reason,
when toggling the feed off, the MagicStackCollectionView receives
safe area insets, even though its final position is well outside of
the safe area. By setting UIContentInsetsReferenceNone to the
UICollectionViewCompositionalLayoutConfiguration, the items are not
inset to safe area insets.

(cherry picked from commit 54807a190664eee381f8332d3331f96f7959dd1f)

Fixed: 333745588
Change-Id: I4e60fe6d555de2a7a953df96559268f0f50d5a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474384
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1293809}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505873
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/branch-heads/6422@{#553}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
1 file changed
tree: 29797858a6030a6ada4e01e48b915c8c9157ae7c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.