Supports all ':has' relative argument cases Currently the relative selector is not supported yet, so this CL provides the relative argument cases as follows. - :has(:scope > <complex-selector>) - :has(:scope ~ <complex-selector>) - :has(:scope + <complex-selector>) This CL provides a wpt test for the above usage. - has-relative-argument.html While matching those argument selectors on the :has argument subtree of an element, we can get the candidate scope elements. By marking those elements as matched, we can reduce the duplicated ':has' argument matching operation. HasArgumentSubtreeIterator provides the way to traverse the ':has' argument subtree (downward subtree of the :has scope element). The iterator provides right-to-left post-order traversal to prevent incorrect 'NotMatched' status. And it also provides a way to limit traversal depth or adjacent distance to prevent unnecessary tree traversal for direct relations (child/direct sibling). About the issue of incorrect 'NotMatched' status, the previous caching logic has a bug of incorrectly using the cached status to skip one argument selector matching operation for one descendant of an element. The cached status should be used to skip the argument matching operations for all the descendants of an element because it is the status of :has scope element. To store the 'NotMatched' status correctly during the ':has' subtree traversal for argument selector matching , the traversal order should be right-to-left reversed post-order to guarantee that, the downward subtree(descendants/next siblings/descendants of next siblings) of an element was checked with the argument selector before checking the element and the previous check didn't mark the element as 'Matched'. The ':has(.descendant)' test case in the 'has-basic.html' missed to have an expected return value related with this bug, so the test result is fixed with this CL. And to check the added/fixed logic, following test are added. - has-relative-argument.html Change-Id: I71f8752ad90d32c6f9ee6bf87949b838e3843eba Bug: 669058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914967 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#894067}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.