commit | 3edde16cdf8674c668feae213bc7795480c6bf7b | [log] [tgz] |
---|---|---|
author | Marijn Kruisselbrink <mek@chromium.org> | Wed May 31 19:39:57 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 31 19:39:57 2023 |
tree | e8b25f9f1f0701a0630b3beeb19b5b40c29f6a0e | |
parent | b0df1ec78ec81d4aef26d9e063c3b0e9e305b5be [diff] |
Reland "Add WebAppIntegration.IncompatibleAppShim test." This is a reland of commit 90c1ec7d9a9c64ffa363b7565178142932e51b97 This relands skips the code-signing step on Mac OS 11 and older, as the codesign tool is not installed there, and also not needed. Original change's description: > Add WebAppIntegration.IncompatibleAppShim test. > > This test aims to cover the same code that the (long disabled) > AppShimInteractiveTest.RebuildShim test did. One differences being > that that test relied on differences in architecture between the app shim > and chrome, while this test relies on differences in the expected entry > point exposed by chrome. Both should result in the same app shim > behavior. > > Another difference is that the old test uses (deprecated) chrome apps > while this test uses PWAs. > > Since this is the only AppShimInteractiveTest that doesn't already > have equivalent tests elsewhere, this should pave the way for deleting > the entire test suite. > > Bug: 509774 > Include-Ci-Only-Tests: true > Cq-Include-Trybots: luci.chrome.try:mac-chrome > Validate-Test-Flakiness: skip > Change-Id: Ifd4160f30d5c10b46ac8ba48b722212a3680d61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569285 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1150996} Bug: 509774 Change-Id: I2250067204a4520ef496e853d9a27069fb5ce145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575580 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1151425}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.