[144] [omnibox][next] Fix classic popup not opening after closing AIM

When closing AIM popup, we share the user's in progress input with the
classic omnibox. Doing so was setting the omnibox state as having input
in progress which prevents zero suggestions.

Classic omnibox opening on click is a side affect of having zero
suggestions to show. In fact, on some sites, where there are no zero
suggestions, classic omnibox doesn't open on click. This used to be
super common, but it's now rare because we have both zero search
suggestions and contextual suggestions.

This CL adjusts the
`OmniboxAimPopupWebUIContent::OnPageClosedWithInput()` code for sharing
user's AIM input with the omnibox to only do so when the AIM input is
not empty. This is consistent with how
`OmniboxEditModel::RestoreState()` does it when switching tabs.

crrev.com/c/7205626 is another example, where `OnPageClosedWithInput()`
needed some logic that was already done in `RestoreState()`. The rest of
the code in `RestoreState()` doesn't seem relevant for
`OnPageClosedWithInput()`, so it doesn't seem like we should leverage
that or a shared helper, but if we continue finding bugs that are
already solved by `RestoreState()`, maybe we should.

(cherry picked from commit 8d206cd3e072c7b8864352fe48012126087115a2)

Bugs: b:463432768, b:463444960, b:462477206, b:462787431, 467113257
Change-Id: I49e52a003fbc101a9f773249244ae26592099aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7209782
Reviewed-by: Khalid Peer <khalidpeer@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1553070}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7240371
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/branch-heads/7559@{#607}
Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
2 files changed
tree: 29d6e9ceb36aa6b32bb835053049b13ca6798cdd
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.