Google GitGoogle Git
Sign in
chromium/chromium/src/3ef93c21026fbcba5d5237f8a85d179ff465a230
commit
3ef93c21026fbcba5d5237f8a85d179ff465a230
[log]
author
Friedrich Horschig <friedrichh@chromium.org>
Thu May 22 14:57:38 2025
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu May 22 14:57:38 2025
tree
18866e50339cee634a3efd29657e264954d06c9a
parent
8ad6db2bf450e62b5badb17cfc27740088dc0df1 [diff]
[Autofill] Use PasswordAutofillManager as PasswordManagerDelegate

The `PasswordAutofillManager` becomes the implementation of the
`PasswordManagerDelegate`. Since there is exactly one manager that is
responsible for a password form, let the `ChromePasswordManagerClient`
find the correct frame for the focused field and provide the manager.
That allows the webcontents-scoped BrowserAutofillManager to trigger the
proper frame-scoped password suggestions.

The implementation of showing happens in https://crrev.com/c/6434113. So
currently, turning on the feature flag results in Chrome not showing any
TTF, accessory or dropdown.

DD: go/apdc-dd
Screencast: screencast/NTQzMDYwMDU0NTU5OTQ4OHw3NmEwNGU3Yy0xNw
Feature: AutofillAndPasswordsInSameSurface
Bug: 399131928, 410743802
Fixed: 399134379
Change-Id: I318df35c97ac9cdad06446e85765f6098166a2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305242
Reviewed-by: Jan Keitel <jkeitel@google.com>
Reviewed-by: Maria Kazinova <kazinova@google.com>
Commit-Queue: Friedrich Hauser <friedrichh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464095}
23 files changed
tree: 18866e50339cee634a3efd29657e264954d06c9a
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.