Google Git
Sign in
chromium / chromium / src / 3f3c57dff38b5f99d3403efc37a273abf6c65b11
commit3f3c57dff38b5f99d3403efc37a273abf6c65b11[log] [tgz]
authorElla Ge <eirage@chromium.org>Fri May 20 18:28:17 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 20 18:28:17 2022
tree6397133ba9199cd0a71e7ab2f0499cafd1fe58a8
parente2bae2d0b1f1e5de66fcdb6629590a1edb30e8d1 [diff]
InstallableManager wait for screenshots fetch to complete

This CL fixes the richer install bottom sheet not showing correctly
with flag "SkipServiceWorkerCheckAll" enabled.

The issue is due to InstallableManager not checking whether the
screenshots fetching was completed. It worked before since
`params.fetch_screenshots` always set together with `params.has_worker`
and worker checks was later/slower than the screenshots.


Bug: 1322139

(cherry picked from commit 6b8adc168319371b7191fd0217882941e0840529)

Change-Id: Id0cbb48cd0f133d4be586e41e8e19b95b285f27c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645338
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1005273}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654645
Commit-Queue: Krishna Govind <govind@chromium.org>
Auto-Submit: Ella Ge <eirage@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#140}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: 6397133ba9199cd0a71e7ab2f0499cafd1fe58a8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.