commit 3f7c841f81ca05e1c25b9ae3721c0df1691f6402
author Joanmarie Diggs <jdiggs@igalia.com> Thu Nov 10 19:29:48 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 10 19:29:48 2022
tree 48f59e51635341e211a1726d38c7804a4c70848a
parent 4b0f6098928f707298633d094d9a19df1458f330

Reland "Reset accessibility on AXMode update"

This is a reland of commit be82cef6def900567e84acd2ea15459217cf2cad.

It had been reverted as a suspected cause of crbug.com/1364487, and the
revert did improve the end-user experience, but did not completely fix
the regression. Further investigation showed that the underlying problem
was due to commit 78735e3dbdb9953bf0a7d31ca92a75c85bf7f40c and
commit 435c9adbf2dea21ff7503148d6b145849718bab8, both of which have
since been reverted. See crbug.com/1379174.

Regarding the specific issue found in crbug.com/1364487, two additional
changes were made: crrev.com/c/3974532 increases the accessibility-API
usage delay from one to five seconds in order to reduce the frequency
with which we update the Active/Inactive time, and crrev.com/c/3982256
delays disabling accessibility support in response to a client being
terminated.

With all of the above changes in place, it should be safe to reland this
change.

AX-Relnotes: n/a

Bug: 1341507

Original change's description:
> Reset accessibility on AXMode update
>
> This change more strictly performs cleanup when accessibility is turned
> off within the browser process.
>
> Specifically, when an AXMode turns off web content accessibility, we will
> destroy BrowserAccessibilityManager. This object would otherwise occupy a
> non-trivial amount of memory.
>
> A speculative benefit of this would be to tighten our assumptions about
> the lifetime of BAM. For instance, if an owning RFHI is reused and
> somehow accessibility is turned back on, we would potentially apply tree
> updates on a stale BAM.
>
> BrowserAccessibilityManager::DetachFromParent is required because of hitting
>
> FATAL:browser_accessibility_manager.cc(1761)] Check failed: parent || !connected_to_parent_tree_node_.
> 3   Chromium Framework                  0x000000012bd6749e logging::LogMessage::~LogMessage() + 14
> 4   Chromium Framework                  0x00000001281291eb content::BrowserAccessibilityManager::GetParentManager() const + 379
> 5   Chromium Framework                  0x000000012812d427 content::BrowserAccessibilityManager::GetParentNodeFromParentTreeAsAXNode() const + 23
> 6   Chromium Framework                  0x000000012812841b content::BrowserAccessibilityManager::GetParentNodeFromParentTree() const + 27
> 7   Chromium Framework                  0x0000000128128263 content::BrowserAccessibilityManager::~BrowserAccessibilityManager() + 67
> 8   Chromium Framework                  0x0000000128a81074 content::BrowserAccessibilityManagerMac::~BrowserAccessibilityManagerMac() + 68
> 9   Chromium Framework                  0x00000001287b3c39 content::RenderFrameHostImpl::UpdateAccessibilityMode() + 281
> 10  Chromium Framework                  0x00000001287c9bcd base::internal::Invoker<base::internal::BindState<base::RepeatingCallback<content::RenderFrameHost::FrameIterationAction (content::RenderFrameHostImpl*)> content::RenderFrameHostImpl::FrameIterationWrapper<content::RenderFrameHostImpl>(base::RepeatingCallback<void (content::RenderFrameHostImpl*)>)::'lambda'(base::RepeatingCallback<void (content::RenderFrameHostImpl*)>, content::RenderFrameHostImpl*), base::RepeatingCallback<void (content::RenderFrameHostImpl*)>>, content::RenderFrameHost::FrameIterationAction (content::RenderFrameHostImpl*)>::Run(base::internal::BindStateBase*, content::RenderFrameHostImpl*) + 93
> 11  Chromium Framework                  0x000000012878af9b content::RenderFrameHostImpl::ForEachRenderFrameHostImpl(base::RepeatingCallback<content::RenderFrameHost::FrameIterationAction (content::RenderFrameHostImpl*)>, bool) + 635
> 12  Chromium Framework                  0x000000012878b30c content::RenderFrameHostImpl::ForEachRenderFrameHostIncludingSpeculative(base::RepeatingCallback<void (content::RenderFrameHostImpl*)>) + 124
> 13  Chromium Framework                  0x00000001289a20e2 content::WebContentsImpl::SetAccessibilityMode(ui::AXMode) + 178
> 14  Chromium Framework                  0x0000000128132661 content::BrowserAccessibilityStateImpl::ResetAccessibilityMode() + 113
> 15  Chromium Framework                  0x000000012b740465 -[BrowserCrApplication accessibilitySetValue:forAttribute:] + 101
> 16  AppKit                              0x00007ff80eb3153a -[NSAccessibilityAttributeAccessorInfo setAttributeValueForObject:withValue:] + 58
>
> Bug: 1341507
> Test: cq
> AX-Relnotes: n/a
>
> Change-Id: I97fb1f5b24456b024d3d9b1960c35512d5277758
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758895
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Abigail Klein <abigailbklein@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1024942}

Change-Id: Id3a98f8f9dfee6cc137022be21349e58ad954b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008398
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1069898}