Google Git
Sign in
chromium / chromium / src / 4ded38ed33da2927224b2bbbadf6edf1c64ac2c6
commit4ded38ed33da2927224b2bbbadf6edf1c64ac2c6[log] [tgz]
authorEhsan Karamad <ekaramad@chromium.org>Thu May 23 15:22:22 2019
committerCommit Bot <commit-bot@chromium.org>Thu May 23 15:22:22 2019
tree9a71cd3e9bdfbfdcadb460586c850ef90de3e058
parent8f6f8bc75db2ca8e45cc7f3956b096b170049a33 [diff]
[ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent

Currently, a MimeHandlerView is created as long as there is a plugin
for it. This behavior undermines issues such as <webview> permissions
API.

This CL will avoid creating MimeHandlerView if the plugin is not
allowed. This change will also make the test
WebViewPluginTest.TestLoadPluginInternalResource pass with the flag
MimeHandlerViewInCrossProcessFrame.

Note that when the plugin is not allowed, no (frame-based)
MimeHandlerView will be created and the code will follow the ordinary
CreatePlugin code path.

Bug: 963694
Change-Id: I91b88956480139ffdb0df06077d099746b713751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662641}
2 files changed
tree: 9a71cd3e9bdfbfdcadb460586c850ef90de3e058
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .