commit | 3fb61ca45c6511a79977f32a047613e981d0f2fc | [log] [tgz] |
---|---|---|
author | Ian Prest <iapres@microsoft.com> | Tue Apr 02 06:08:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 02 06:08:23 2019 |
tree | 40c238a40412c267b723d0ffedb7c9f211dc9f94 | |
parent | e4a13ed909cf62f0d7d634e4a0b72b7bbfafd846 [diff] |
Parameterize accessibility "dump" tests The accessibility dump tests (both tree-dump and event-dump) execute multiple passes for each test. Most OSes run two passes (Blink + Native), but on Windows we recently introduced a third pass for UIA. The addition of the UIA pass required that we toggle an experimental command-line flag to ensure that UIA is properly enabled/disabled. Unfortunately, modifying the command-line multiple times during the test ran afoul of the ThreadSanitizer, which reported a data-race condition. This required that the dump tests be parameterized, so that each "pass" now runs independently, and can update their command line only once. Note: "gtest_filter" now requires a "/xxx" suffix, e.g.: --gtest_filter=DumpAccessibilityEventsTest.ValueValueChanged/* Bug: 946481, 928949 Change-Id: I6490f33681b5567b6584442c9cf241611b3b5baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542692 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#646672}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .