WebApp: Move shortcuts menu downloaded icon sizes into item info struct Previously WebApp had two separate fields: vector<WebAppShortcutsMenuItemInfo> shortcuts_menu_item_infos_; vector<IconSizes> downloaded_shortcuts_menu_icons_sizes_; These were required to be the same length as they together recorded information about the same thing (each index corresponds to an entry in the shortcuts menu). This was both unergonomic and error-prone (see attached bug). This CL adds an IconSizes field to the WebAppShortcutsMenuItemInfo struct so that there is always exactly 1 IconSizes per ItemInfo. No functional changes. Bug: 1427444 Change-Id: I055af4411c887124a120b912e1221d5848258975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619949 Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/main@{#1160992}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.