commit | 3ffe34c66fc95b9b8e2fd2cf45fa4aea86617df8 | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Tue Jun 25 18:20:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jun 25 18:20:01 2019 |
tree | 6d0a34c53f1cd223171cd13677b64097147a6b11 | |
parent | 43680be2f276873580864e790209212c9c87a34d [diff] |
Run android startup tasks asyncronously in browser tests as in prod The android startup tasks were run synchronously when a |ui_task| was present (ie in browser tests) because android browser tests were expecting synchronous initialization, however java initialization is asynchronous anyways. So we have a RunLoop in BrowserTestBase pumping tasks and waiting for java initialization to complete, which is done as a (possibly asynchronous) side effect of the |ui_task| running. Thus we can stop branching here for tests and just post the startup tasks in browser tests as we would do normally in production. And the RunLoop in BrowserTestBase::SetUp() will run them all, eventually running the |ui_task|. R=avi@chromium.org Bug: 961849 Change-Id: Ic4724895e7b3762c401f2e781907816e2048e1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671069 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672154}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .