Google Git
Sign in
chromium / chromium / src / 4020e48366530939e4eb2a597c4125f56916a213
commit4020e48366530939e4eb2a597c4125f56916a213[log] [tgz]
authormanukh <manukh@chromium.org>Mon Oct 24 23:46:53 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 24 23:46:53 2022
tree169fcdebc4e551698d49d81810737512db957803
parenta76a94da8b5ad7f95bfeea280966b3517db6b32a [diff]
[omnibox][shortcut] Cleanup `ShortcutsProvider`.

The previous CL crrev.com/c/3965472 cleaned up
`SP::CalculateScoreFromFactors()` specifically. This CL cleans up the
rest of the SP.

Specifically:

- Remove unused include & method
- Replace lambdas with param defaults `less {}`
- Replaced `.first` and `.second` with structured binding
- Dedupe constructing an equivalent `Shortcut` in 2 places

No behavior change.

Bug: 812673, 252032
Change-Id: I4a51e3e8f19e2a210d7c39a2f947ad4a0eb73012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3969741
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Marlon Facey <mfacey@google.com>
Cr-Commit-Position: refs/heads/main@{#1063079}
1 file changed
tree: 169fcdebc4e551698d49d81810737512db957803
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.