Make GetServiceWorkerRaceNetworkRequestToken returns optional

A speculative fix for crbug.com/1492640. We're seeing some URL mismatch
inside the custom URLLoaderFactory.

When ServiceWorkerAutoPreload is enabled, URLLoaderFactory being used
from the fetch handler is replaced with the corresponding custom
URLLoaderFactory for the dedupe purpose. This is basically done via the
hash map, which has a token string as a key and URLLoaderFactory as a
value.

The token is set in `service_worker_race_network_request_token_` in the
ResourceRequest class, and the hash map lookup is done in the
LoaderFactoryForWorker::CreateURLLoader. The token is set if the request
is HTTP, however, `service_worker_race_network_request_token_` is not
initialized if the request is not HTTP e.g. extensions, and that allows
the browser to lookup the hash map with uninitialized key, which is not
indended.

This may not be a root cause but we could fix the crash by avoiding the
unexpected hash map lookup.

Bug: 1492640
Change-Id: I1db86bd96102594c227961e40cc39cab9343a90f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4945316
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1211216}
2 files changed
tree: 6c79c977351bda710bf33d635708701fe731747e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.