Google Git
Sign in
chromium / chromium / src / 407f3a036ee21e205185c9389d362661950ddb48
commit407f3a036ee21e205185c9389d362661950ddb48[log] [tgz]
authorNoam Rosenthal <nrosenthal@chromium.org>Thu Mar 13 11:59:51 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 13 11:59:51 2025
treede15da17464fe04f09ce63679a60abd9e11bbf1f
parentae535cf6e1f44b33c7c79115fcfbfe31d06243f9 [diff]
corner-shape: use real superellipse as reference

Use a superellipse formula instead of bezier approximation for
creating the corner-shape references.
This ensures that we're honest about what we render.

Since the bezier version is an approximation, the fuzz factor
needs to be pretty high and the radii need to be pretty low.

We can iteratively try to improve the formula and reduce the fuzz
as we move forward.

Note that the test is ported from a prototype, and include
border rendering that is not utilized yet.

This exposed issues with how the approximation renders concave shapes,
opened https://issues.chromium.org/issues/402910367 and removed them
from the variants until fixed.

R=pdr

Bug: 394059604
Change-Id: I8f45b88f20ba5b9d9cb1474c8939400b53f68457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6349037
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1432033}
8 files changed
tree: de15da17464fe04f09ce63679a60abd9e11bbf1f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.