Google Git
Sign in
chromium / chromium / src / 40cb7299f7d30617fc98914e8c2f498234e08f6b
commit40cb7299f7d30617fc98914e8c2f498234e08f6b[log] [tgz]
authorDavid Bertoni <dbertoni@chromium.org>Wed May 11 20:09:28 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 11 20:09:28 2022
treefd85b28795487c47e38852319b76404981ae4f63
parent27fe92b2a5b063dae180a4f8057eba768643cc01 [diff]
[CodeHealth] Remove uses of ListValue::Append in /chrome/browser/ash/app_mode.

This CL removes uses of the overload that accepts a
std::unique_ptr<base::Value>. It attempts to modernize code where
feasible and uses base::Value::FromUniquePtrValue where it's not.

This CL was uploaded by git cl split.

R=anqing@chromium.org

Bug: 1187097
Change-Id: I99d83a68c2b849a68f597018832a152d2d5b3a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3640226
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1002271}
2 files changed
tree: fd85b28795487c47e38852319b76404981ae4f63
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.