commit | 41153d8c546533b998a0ccfe3119651e4f7affc5 | [log] [tgz] |
---|---|---|
author | Victor Hugo Vianna Silva <victorvianna@google.com> | Wed Feb 23 14:52:45 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 23 14:52:45 2022 |
tree | 51559b88e65b6d9b00e0988dd275c76195ee8f44 | |
parent | 0bbeb9def59cb1aaa3b7f8d782f041b66de06c5e [diff] |
Always enable send-tab-to-self receiving if user has sync consent This change concerns devices that consented to sync but: a) disabled "Open tabs" in chrome://settings/syncSetup/advanced; or b) have SyncRequested set to false (mainly one legacy state on mobile). Those devices will now be valid targets for the send-tab-to-self feature (STTS) instead of being filtered. The rationale can be found in the linked bug. The change is landed behind a kill switch because it will cause DEVICE_INFO commits when the send_tab_to_receiving_enabled field [1] is set to true. I will note that even though all modern clients now set this field to true, there's no plan to remove it, because: a) it allows unlaunching STTS if ever needed; and b) versions predating STTS must be filtered anyway (the field defaults to false). [1] https://source.chromium.org/chromium/chromium/src/+/main:components/sync/protocol/device_info_specifics.proto;l=103;drc=166e3c6b0b6418cf5a08713861fc15dbcd20c009 Bug: 1299833 Change-Id: Ifcfec1fc8dc224b5a358f177a7086dcb90541a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483939 Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#974170}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.