Always enable send-tab-to-self receiving if user has sync consent

This change concerns devices that consented to sync but:
a) disabled "Open tabs" in chrome://settings/syncSetup/advanced; or
b) have SyncRequested set to false (mainly one legacy state on mobile).
Those devices will now be valid targets for the send-tab-to-self feature
(STTS) instead of being filtered. The rationale can be found in the
linked bug.

The change is landed behind a kill switch because it will cause
DEVICE_INFO commits when the send_tab_to_receiving_enabled field [1] is
set to true.

I will note that even though all modern clients now set this field to
true, there's no plan to remove it, because:
a) it allows unlaunching STTS if ever needed; and
b) versions predating STTS must be filtered anyway (the field defaults
to false).

[1] https://source.chromium.org/chromium/chromium/src/+/main:components/sync/protocol/device_info_specifics.proto;l=103;drc=166e3c6b0b6418cf5a08713861fc15dbcd20c009

Bug: 1299833
Change-Id: Ifcfec1fc8dc224b5a358f177a7086dcb90541a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483939
Commit-Queue: Victor Vianna <victorvianna@google.com>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974170}
4 files changed
tree: 51559b88e65b6d9b00e0988dd275c76195ee8f44
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.