Google Git
Sign in
chromium / chromium / src / 417487aa1a74505443dd9753236c61a0cb4afdae
commit417487aa1a74505443dd9753236c61a0cb4afdae[log] [tgz]
authorAndreea Costinas <acostinas@google.com>Thu Jan 25 09:46:21 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 25 09:46:21 2024
tree290dfedd43a38935299dd04f6094c946b1e0ccd5
parentf437364cd6d1c20fcefc63b6c5026b5d8723cc97 [diff]
Always replace device placeholders in DoH URI templates

Currently, if the DoH URI template contains placeholders for device
identifiers these placeholders are ignored for unaffiliated users.

This is incorrect because the template delimiters are not URL encoded
and it breaks the DoH server assumptions regarding the size of the
identifier replacement.

This CL changes the current logic by hashing and hex encoding the
value of the placeholder name for users which are not affiliated.

E.g. the replacement for ${DEVICE_ASSET_ID} is
uppercase_hex(sha256(VALUE_NOT_AVAILABLE)).

Bug: b/315422225
Change-Id: If142d012b11379a9c44aa71389463c43609736ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5211015
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Andreea Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/main@{#1251974}
3 files changed
tree: 290dfedd43a38935299dd04f6094c946b1e0ccd5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.