Google Git
Sign in
chromium / chromium / src / 41c1694b99567d525a9c31e2d9f26d338cefee48
commit41c1694b99567d525a9c31e2d9f26d338cefee48[log] [tgz]
authorPaul Adedeji <pauladedeji@google.com>Thu Oct 26 21:22:14 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 26 21:22:14 2023
tree3dd8de351655eec26759efaed83acfa19f356002
parenta9bc06905ddc961af35bfd7c3275fc14f1ae4f5f [diff]
Add more styling to combobox.

1. Makes all dropdown items inherit the background color, text color, width of their combobox.
2. Gives the first child a radius so that when it is hovered or selected it looks good.
3. Adds hover color.
4. Updates demo "highlighted" color to increase contrast with the other colors used. This is a random color I chose.

*Video demo of all three menus in bug comments*

Before: b-screenshot/8usrXZKWHNt7MrS

After:  b-screenshot/4FfK8rFRnkrD73s
        a-screenshot/3Z9DGoDCksqNpYA
        c-screenshot/5wJNuq5yhMHRVZk

Change-Id: I31e560677158a2d560082bac35ae3cd34a039905
Bug: b/307952495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980316
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1215747}
2 files changed
tree: 3dd8de351655eec26759efaed83acfa19f356002
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.