Google Git
Sign in
chromium / chromium / src / 423bc8f5bf7aec04e5489bc7e643e6a89faaab11
commit423bc8f5bf7aec04e5489bc7e643e6a89faaab11[log] [tgz]
authorMy Nguyen <myy@chromium.org>Thu Sep 10 14:17:32 2020
committerCommit Bot <commit-bot@chromium.org>Thu Sep 10 14:17:32 2020
tree0cbe0f75b88b240d3ad9837e927f8b4df418b818
parentf9edd96968c8341865e139b62a8e76514d473fb3 [diff]
[OsSettingsLanguages] Update spellcheck pref when dictionary is empty

The logic in settings side is added in https://crrev.com/c/1600384.
Main logic is to turn off kSpellcheckEnable when spell check is off
for the 1 supported language.

This is equivalent to turning off kSpellcheckEnable when
hun_dictionaries is empty as it has similar origin to spellCheckEnable.
They both come from users' spellcheck dictionaries pref, forced and
blocked dictionaries list.

More background: http://go/cros-lang-settings-spell-check-migrate

Update the test in languages_page_test.js to better reflect users's
action.

Side effect:
Originally, when users turn off spell check for all languages, spell
check is left on. Now, when they turn the last one off, spell check is
off as well.

Related CL: https://crrev.com/c/2360093
Drive-by: Remove unused SetSingleLanguageDictionary function in test.

Bug: 1113439
Change-Id: Id8700c3b357da53e22e5f79420b163c8ef50b2d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390300
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805734}
4 files changed
tree: 0cbe0f75b88b240d3ad9837e927f8b4df418b818
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.