Google Git
Sign in
chromium / chromium / src / 4268dcfcc6028da49221b274ae3b73b0753fd9a2
commit4268dcfcc6028da49221b274ae3b73b0753fd9a2[log] [tgz]
authorUtkarsh Pathak <utpathak@microsoft.com>Thu Jul 25 12:20:55 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 25 12:20:55 2024
treea19d1a2947e56931a3682743d56fa538da0e5885
parent1b5f02dcf1f2b670ccff42986c200007a325c22b [diff]
Input event data should not be null when replace selection command is performed


As per spec
https://www.w3.org/TR/input-events-1/#overview, event data for input
events with certain inputType should be set with the data under
operation. Currently, the event data is null since the method
|TextDataForInputEvent| was not implemented in |ReplaceSelectionCommand|
class, which is implemented in this CL. |ReplaceSelectionCommand|
objects are populated with insertFromDrop, insertFromPaste,
insertReplacementText, insertTranspose and none inputType. This change
will set the data for input events with inputType insertFromDrop,
insertFromPaste and insertReplacementText leaving the insertTranspose
and none inputType data null as per the spec. For other input types,
other class objects derived from |EditCommand| are created, which is not
in the scope of this CL and can be handled separately.


Bug: 40737336
Change-Id: Ia7557f4d4fb239585be8fbcc5cdb489b77799c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605567
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Utkarsh Pathak <utpathak@microsoft.com>
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1332887}
9 files changed
tree: a19d1a2947e56931a3682743d56fa538da0e5885
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.