commit | 4278951c5f92b00a61661d0a4de0509f412186f3 | [log] [tgz] |
---|---|---|
author | Steinar H Gunderson <sesse@chromium.org> | Mon Jan 10 14:30:09 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 10 14:30:09 2022 |
tree | 0b9a2a698902ffbbc8b888e097b6dd05077e2f4f | |
parent | 0bc0ab4cde6ea1801c27ac4c0d515be0a57ba4a8 [diff] |
Revert "Mark the CSS “color” property as independent." This reverts commit 8369b120a211aa75dd14c91b62036a44b5a74bb3. Reason for revert: Triggered a bug in the Jinja code generation templates, causing various performance issues. Will reland after some other fixes. Original change's description: > Mark the CSS “color” property as independent. > > This allows the color property to be changed and propagate > down the DOM tree without requiring a full restyle, bringing > performance benefits. In particular, the “design” test in > MotionMark gets a roughly 40% higher score with this patch. > > color isn't actually strictly independent; there are cases > where it affects other properties (such as border-color), > and since it also decides currentColor, we need to take some > extra care in invalidating elements depending on that. > However, this is already done, so the change itself is safe. > > The only real change is that we needed to modify the custom > value application member function for the color property; > when color becomes independent, it also gets an “inherited” > flag that we need to set, as the the propagation of independent properties > (ComputedStyleBase::PropagateIndependentInheritedProperties()) > depends on this flag to be correct. > > Change-Id: I1cd812a531dbb3216f8cade2b429631e1b1bb60b > Fixed: 1284225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3361852 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Steinar H Gunderson <sesse@chromium.org> > Cr-Commit-Position: refs/heads/main@{#956102} Change-Id: Icf32e29a1165e1c0d2897f11cdbd332d8797e158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3376902 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#957053}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.