Google Git
Sign in
chromium / chromium / src / 42a7aba111bae4f6e6de447bb5874e19e866d5a2
commit42a7aba111bae4f6e6de447bb5874e19e866d5a2[log] [tgz]
authoranthie@google.com <anthie@google.com>Fri Jun 28 15:10:03 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 28 15:10:03 2024
tree658482cdbc884ec79111064576aab02f07ab2735
parent94ac2a667d6cc8a6c72053b57ad7fe6c8c7e4fb1 [diff]
Fix Supervised User extension install metrics on "Skip Approval"-mode

The metrics for the Extension Installation dialog (the same dialog
that is used by non-supervised users) should be recorded for supervised
user when the "Skip parent approval"-mode is enabled.

This change re-enables observing the states of the
Extension Installation dialog dialog for supervised users,
when parental controls apply on Extensions.
The deprecated state "Request parent approval" is cleaned up
for where is was previously tracked. The state was only
meaningful for an old use-case of the dialog, which no longer exists.
A new state ("Child Accepted") is introduced instead and tracked
when the child proceeds with an extension installation in the
"Skip parent approval"-mode.

Bug: b/321240396, b/349322029
Change-Id: Iadbd2ef4062475be83053536f728db7e85bdc260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645669
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Anthi Orfanou <anthie@google.com>
Reviewed-by: Courtney Wong <courtneywong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1320974}
7 files changed
tree: 658482cdbc884ec79111064576aab02f07ab2735
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.