Google Git
Sign in
chromium / chromium / src / 42d27da6f1a9d0035a6025755e7d7e2c0b1e19b7
commit42d27da6f1a9d0035a6025755e7d7e2c0b1e19b7[log] [tgz]
authorkenoss <kenoss@chromium.org>Tue Feb 25 10:52:44 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 25 10:52:44 2025
tree670e4c67f56c1b08a79d524800873410e0d939e1
parent5333bc8f9293d4623ecedbfd8ed5c8b37dff1b65 [diff]
[M134] Prerender2Fallback: Mitigate crash due to use-after-dtor of DocumentUserData

We found that there is a case that uses `DevToolsPreloadStorage` after
`DocumentAssociatedData::dtor()`, which is forbidden and cause a crash.
To mitigate this, this CL calls
`DevToolsPreloadStorage::GetOrCreateForCurrentDocument()` ahead and
checks `DevToolsPreloadStorage::GetForCurrentDocument()` to get knowing
`DocumentAssociatedData::dtor()` is already called or not.

For more details, see
https://docs.google.com/document/d/1ZP7lYrtqZL9jC2xXieNY_UBMJL1sCrfmzTB8K6v4sD4/edit?resourcekey=0-fkbeQhkT3PhBb9FnnPgnZA&tab=t.e4x3d1nxzmy3#heading=h.4lvl0yr9vmh7

(cherry picked from commit ec0728594435df87a6d68330661506577231aaba)

Fixed: 394631076
Change-Id: I701ff6b0bb2bc50d4347d270dc4132490a437333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6268901
Commit-Queue: Ken Okada <kenoss@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1421801}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6285146
Auto-Submit: Ken Okada <kenoss@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/branch-heads/6998@{#1440}
Cr-Branched-From: de9c6fafd8ae5c6ea0438764076ca7d04a0b165d-refs/heads/main@{#1415337}
2 files changed
tree: 670e4c67f56c1b08a79d524800873410e0d939e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.