commit 42e1c42bf081825a59ed3ff48ff62fba88b36488
author Kavita Soni <kavitasoni@chromium.org> Thu Feb 27 22:09:09 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 27 22:09:09 2025
tree d5b7683076beddd09637c5991cc6bc54f97e999b
parent 9016fa3e2d77a888b44455071b95f687b0047f15

Don't default save card fix flow detection bits on iOS.

Before this CL, detected values on credit card form submission were
always set with `DetectedValue:USER_PROVIDED_NAME` and
`DetectedValue:USER_PROVIDED_EXPIRATION_DATE` bits on iOS. Presence
of these bits impacted `AutofillMetrics::CardUploadDecisionMetric`
indicating fix flow is always present. The detected values are passed
in the payments server request while uploading the card.
However CreditCardSaveManager's `should_request_name_from_user_` &
`should_request_expiration_date_from_user_` were always set to false.
This worked on iOS since fix flow is not a separate flow step. If user
has submitted a form with missing data, the save card infobar modal
lets user enter the data in the modal itself.

After this CL, `DetectedValue` bits would only be set if
cardholder name or valid expiry date is missing AND a save card modal
will be offered to collect them. CreditCardSaveManager's
`should_request_name_from_user_` &
`should_request_expiration_date_from_user_` won’t be defaulted to
false. This is needed to support Save Card Bottomsheet experiment on
iOS which will be shown when fix flow is not detected. Save card modal
will be shown when fix flow is detected.
`AutofillMetrics::CardUploadDecisionMetric` will have fix flow bits
set only when data is missing during form submission. Same for the
`DetectedValue` bits received by the payments server request.

A kill-switch flag `kAutofillDisableDefaultSaveCardFixFlowDetection`
has been added for the change affecting DetectedValue bits.

Followup CL updates existing fix flow detection tests in
CreditCardSaveManagerTest disabled for iOS and adds iOS-specific tests.

Bug: 391930098
Change-Id: Ib8717c8b234652abbbb2f919262627aaeeae82a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6238383
Commit-Queue: Kavita Soni <kavitasoni@chromium.org>
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Reviewed-by: Olivia Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/main@{#1425975}