Google Git
Sign in
chromium / chromium / src / 42e3c63b566c7318c9057cc0d6facc0221171778
commit42e3c63b566c7318c9057cc0d6facc0221171778[log] [tgz]
authorPatrick Noland <pnoland@google.com>Wed Aug 24 18:13:43 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Aug 24 18:13:43 2022
tree4ec910f0cb92d8309591f3c9f503721b3ced9c99
parent72e427d31caa6d8b08f0674b078a0bc06f5636af [diff]
[Journeys] Prevent flash of optout text on selection mode action

This was happening because we were synchronously changing the menu group
visibility when the selection state cleared. There's no need to do this
for "open in new tab" or "open in incognito" because these will cause
the view to detach and clear the selection state a little later. I'm
choosing to punt on the solution for "copy" because I can't come up with
something simple

Bug: 1352078
Change-Id: I7b628ed150492eb9c246236e6a3c9b9deec308eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838640
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038861}
1 file changed
tree: 4ec910f0cb92d8309591f3c9f503721b3ced9c99
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.