commit | 42fa4c2f60dcd4fca521ff7a352565eb896ab7b5 | [log] [tgz] |
---|---|---|
author | Thomas Nguyen <tungnh@google.com> | Wed Nov 06 14:29:16 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 06 14:29:16 2024 |
tree | c3a400c9a4b1c7af5223c44d8dbf5adf22ff88d1 | |
parent | e2c06649e7e43f2d6b068dcce29ac5422d2da868 [diff] |
Reland "[PEPC] Snapshot permission statuses at commit navigation" This is a reland of commit 1924a27af38a16c920fa5e09e1ca9b26e75e7195 Changes compared to original CL: - A null check for the frame (when we moved stuff from AttachLayout to InsertedInto) - Remove conditions CHECKs when calling UnregisterClient Original change's description: > [PEPC] Snapshot permission statuses at commit navigation > > When <permission> element is added to the DOM, we'll use IPC to check > the permission status and it'll update when the IPC callback is > triggered. This might cause a flicker if the status changes from ASK > to GRANTED. > > We propose to snapshot permission statuses and cache the statuses at > the execution context, outlined in: https://docs.google.com/document/d/1pfuiJ7BIdX0dxMzboYIOvPV1mFKQ3HE_11VQNeBJSCc/edit?resourcekey=0-9el74tCe5opJXh3CIPyPGA&tab=t.0#heading=h.8zmwced28dbp > > Bug: 368238224 > Change-Id: Ib319301d0b9bedb07502a09b4f030d3e40844ea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905369 > Reviewed-by: Thomas Nguyen <tungnh@chromium.org> > Commit-Queue: Thomas Nguyen <tungnh@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> > Auto-Submit: Thomas Nguyen <tungnh@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1372969} Bug: 368238224 Change-Id: Idb09359fa342393a6fa0956d057955c45e68e723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972695 Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Nguyen <tungnh@chromium.org> Reviewed-by: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378977}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.