Google GitGoogle Git
Sign in
chromium/chromium/src/436c91c5772beccb46bb83973e5f74c8361a9a7a
commit
436c91c5772beccb46bb83973e5f74c8361a9a7a
[log]
author
Cristian Ciacu <cristianciacu@google.com>
Wed Oct 02 20:25:01 2024
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Oct 02 20:25:01 2024
tree
bf93e053f4fa446633c36b9d7e1d8cc21f36e91c
parent
76ee776747c63e0f1fbd518853d1c89bab7bbea8 [diff]
[iOS][LastVisited] Fix failing test in PageInfoTestCase

`testOpeningURLFromFullHistoryDismissesPageInfo` was failing because
the previous visit to the current domain took place one hour ago from
the moment the test is ran, and in the case that takes place anytime
between 12AM and 1AM, the previous visit would be placed in the day
before, causing the creation of two entries in the full history. The
bug happened because the test expected only one entry.

The fix includes: 1) previous visit only takes place one day ago,
rather than one hour ago and 2) the matcher now expects multiple
history entries and selects the oldest one.

Bug: 370898664
Change-Id: I207f3f836f74633176409a69f4942712bebe2e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903896
Commit-Queue: Cristian Ciacu <cristianciacu@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/main@{#1363271}
1 file changed
tree: bf93e053f4fa446633c36b9d7e1d8cc21f36e91c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.