Google Git
Sign in
chromium / chromium / src / 437dab2ec38a6a3dc5073fe44e5d1dffc1b3b2d2
commit437dab2ec38a6a3dc5073fe44e5d1dffc1b3b2d2[log] [tgz]
authorLauren Winston <lwinston@google.com>Mon May 05 21:28:49 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 05 21:28:49 2025
tree9dbe61e0d8c28f174d3ca523a2be85a16a2e94ee
parent0eb8b44e602a29d423a5ec00cf62b0e346633fd2 [diff]
[Read aloud] Don't send event updates if speech state hasn't changed.

For some reason, onSpeechPlayingStateChanged is getting triggered
when the property hasn't actually changed.

This is causing crashes because reading mode is incorrectly
sending event updates on a page change when there's no speech.

This should provide a more permanent fix for crbug.com/415805308.

This may likely be contributing to the Unserialize crashes in
crbug.com/409110161 too, but more testing is needed to verify this.

Bug: 409110161
Change-Id: I2bb04d9e450ae97ec2ac676e8f3c15ea7e8059ce
Fixed: 415805308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514631
Commit-Queue: Lauren Winston <lwinston@google.com>
Reviewed-by: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1455945}
1 file changed
tree: 9dbe61e0d8c28f174d3ca523a2be85a16a2e94ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.